This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed whilst reviewing #20 that we were using an async lock for the InMemoryStore, for no obvious reason. No long-running or async operations take place under a lock, and so an async lock will just be slower, and more complicated, than a simple synchronous lock.
This PR also switches to parking_lot as it is faster, simpler and smaller than the standard library abstractions, and is pretty ubiquitous.