Skip to content

Commit

Permalink
fix tests, remove debug prints
Browse files Browse the repository at this point in the history
  • Loading branch information
jipperinbham committed Aug 14, 2015
1 parent 3145a73 commit 0ae5075
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 6 deletions.
2 changes: 0 additions & 2 deletions outputs/datadog/datadog.go
Expand Up @@ -78,9 +78,7 @@ func (d *Datadog) Write(bp client.BatchPoints) error {
}
req.Header.Add("Content-Type", "application/json")

fmt.Printf("making POST call\n")
resp, err := d.client.Do(req)
fmt.Printf("POST call made, err is: %+v\n", err)
defer resp.Body.Close()
if err != nil {
return fmt.Errorf("error POSTing metrics, %s\n", err.Error())
Expand Down
16 changes: 12 additions & 4 deletions outputs/datadog/datadog_test.go
Expand Up @@ -30,7 +30,9 @@ func testData() client.BatchPoints {
bp.Time = time.Now()
bp.Tags = map[string]string{"tag1": "value1"}
bp.Points = []client.Point{
Fields: map[string]interface{}{"value": 1.0},
{
Fields: map[string]interface{}{"value": 1.0},
},
}
return bp
}
Expand All @@ -43,7 +45,10 @@ func TestUriOverride(t *testing.T) {
defer ts.Close()

d := NewDatadog(ts.URL)
err := d.Write(testData())
d.Apikey = "123456"
err := d.Connect()
require.NoError(t, err)
err = d.Write(testData())
require.NoError(t, err)
}

Expand All @@ -59,11 +64,14 @@ func TestBadStatusCode(t *testing.T) {
defer ts.Close()

d := NewDatadog(ts.URL)
err := d.Write(testData())
d.Apikey = "123456"
err := d.Connect()
require.NoError(t, err)
err = d.Write(testData())
if err == nil {
t.Errorf("error expected but none returned")
} else {
require.EqualError(t, fmt.Errorf("error POSTing metrics, "), err.Error())
require.EqualError(t, fmt.Errorf("received bad status code, 500\n"), err.Error())
}
}

Expand Down

0 comments on commit 0ae5075

Please sign in to comment.