Remove debug logging; add comment; move up

influxdata · Mar 18, 2024 · 52b8a5b · 52b8a5b
1 parent ec38ea5
commit 52b8a5b
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/plugins/inputs/knx_listener/knx_listener.go b/plugins/inputs/knx_listener/knx_listener.go
@@ -132,6 +132,12 @@ func (kl *KNXListener) Stop() {
 
 func (kl *KNXListener) listen() {
 	for msg := range kl.client.Inbound() {
+		if msg.Command == knx.GroupRead {
+			// Ignore GroupValue_Read requests as they would either
+			// - fail to unpack due to invalid data length (DPT != 1) or
+			// - create invalid `false` values as their data always unpacks `0` (DPT 1)
+			continue
+		}
 		// Match GA to DataPointType and measurement name
 		ga := msg.Destination.String()
 		target, ok := kl.gaTargetMap[ga]
@@ -142,10 +148,6 @@ func (kl *KNXListener) listen() {
 			}
 			continue
 		}
-		if msg.Command == knx.GroupRead {
-			kl.Log.Debugf("Ignoring GroupRead for GA %q from %q", ga, msg.Source.String())
-			continue
-		}
 
 		// Extract the value from the data-frame
 		err := target.datapoint.Unpack(msg.Data)