Skip to content

Commit

Permalink
Exclude master_replid fields from redis input (#3725)
Browse files Browse the repository at this point in the history
  • Loading branch information
danielnelson committed Jan 30, 2018
1 parent 1b0a4e4 commit c28d0e1
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 0 deletions.
1 change: 1 addition & 0 deletions plugins/inputs/redis/README.md
Expand Up @@ -90,6 +90,7 @@ Additionally the plugin also calculates the hit/miss ratio (keyspace\_hitrate) a
- master_link_down_since_seconds(int, number)
- master_link_status(string)
- master_repl_offset(int, number)
- second_repl_offset(int, number)
- repl_backlog_active(int, number)
- repl_backlog_size(int, bytes)
- repl_backlog_first_byte_offset(int, number)
Expand Down
4 changes: 4 additions & 0 deletions plugins/inputs/redis/redis.go
Expand Up @@ -207,6 +207,10 @@ func gatherInfoOutput(
}
}

if strings.HasPrefix(name, "master_replid") {
continue
}

if name == "mem_allocator" {
continue
}
Expand Down
4 changes: 4 additions & 0 deletions plugins/inputs/redis/redis_test.go
Expand Up @@ -86,6 +86,7 @@ func TestRedis_ParseMetrics(t *testing.T) {
"repl_backlog_size": int64(1048576),
"repl_backlog_first_byte_offset": int64(0),
"repl_backlog_histlen": int64(0),
"second_repl_offset": int64(-1),
"used_cpu_sys": float64(0.14),
"used_cpu_user": float64(0.05),
"used_cpu_sys_children": float64(0.00),
Expand Down Expand Up @@ -189,7 +190,10 @@ latest_fork_usec:0
# Replication
role:master
connected_slaves:0
master_replid:8c4d7b768b26826825ceb20ff4a2c7c54616350b
master_replid2:0000000000000000000000000000000000000000
master_repl_offset:0
second_repl_offset:-1
repl_backlog_active:0
repl_backlog_size:1048576
repl_backlog_first_byte_offset:0
Expand Down

0 comments on commit c28d0e1

Please sign in to comment.