Skip to content

Commit

Permalink
test: actually skip flaky snmp test (#11199)
Browse files Browse the repository at this point in the history
This test had a short skip added to it four years ago and a comment that
the test has random failures. While working on the integration tests,
which run all tests this test started showing up in the errors.

While the two asserts at the end could possibly be updated, it is worth
having someone look deeper into understanding why this change is
required.

In order to get integration tests running, this skips this test always.
  • Loading branch information
powersj authored and MyaLongmire committed Jul 6, 2022
1 parent e30b2f1 commit e83afe1
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions plugins/inputs/snmp/snmp_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -514,9 +514,8 @@ func TestGetSNMPConnection_caching(t *testing.T) {
}

func TestGosnmpWrapper_walk_retry(t *testing.T) {
if testing.Short() {
t.Skip("Skipping test due to random failures.")
}
t.Skip("Skipping test due to random failures.")

srvr, err := net.ListenUDP("udp4", &net.UDPAddr{})
require.NoError(t, err)
defer srvr.Close()
Expand Down

0 comments on commit e83afe1

Please sign in to comment.