Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why does procstat plugin store PID as a tag? #1460

Closed
beckettsean opened this issue Jul 7, 2016 · 6 comments · Fixed by #1492
Closed

why does procstat plugin store PID as a tag? #1460

beckettsean opened this issue Jul 7, 2016 · 6 comments · Fixed by #1492
Labels
bug unexpected problem or unintended behavior

Comments

@beckettsean
Copy link
Contributor

Seems like the process ID should be a field not a tag, in order to reduce series cardinality. I'm not sure I see a compelling use case for GROUP BY pid, given that over time each process name could generate over 32000 series. If pid was a field it would still be possible to search for a specific PID, although regex doesn't work on fields.

@sparrc sparrc added the bug unexpected problem or unintended behavior label Jul 7, 2016
@sparrc
Copy link
Contributor

sparrc commented Jul 7, 2016

I agree this should probably be a field, cc @daviesalex @sebito91

@daviesalex
Copy link

I think this is basically the same issue as #1451 albeit with a different proposed fix.

We do need to fix this, for sure. Moving to a field is one thing, but searching on tags is convenient - but if you only do this for processes. I'll add this comment to that issue

@daviesalex
Copy link

Also, boring fact that turned out to be relevant for us when we moved to RHEL, pid_max can be set to PID_MAX_LIMIT which is 2^22 in modern kernels by default. The default is now 32768; it was lower in older kernels.

@aderumier
Copy link

Hi,I'm also hitting this bug, I have around 150000 uniques values in pid tag (and around 2000 hosts in host tag).
I think this is why my influxdb take 1h to start .

sparrc added a commit that referenced this issue Jul 14, 2016
sparrc added a commit that referenced this issue Jul 14, 2016
sparrc added a commit that referenced this issue Jul 14, 2016
@rikaardhosein rikaardhosein mentioned this issue Oct 4, 2016
3 tasks
@adrianlzt
Copy link
Contributor

I have found that have the cardinality problem because of this.
Is there any way to "clean" the pid as a tag?
I see that "pid" is listed as a tag and as a value.

@sparrc
Copy link
Contributor

sparrc commented Jan 20, 2017

in release 1.2 you will be able to drop the pid using a config option in the plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants