Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modbus input plugin sample_metric.conf contains malformed toml syntax #14878

Closed
cwedel opened this issue Feb 22, 2024 · 1 comment · Fixed by #14883
Closed

modbus input plugin sample_metric.conf contains malformed toml syntax #14878

cwedel opened this issue Feb 22, 2024 · 1 comment · Fixed by #14883
Labels
feature request Requests for new plugin and for new features to existing plugins

Comments

@cwedel
Copy link

cwedel commented Feb 22, 2024

Use Case

I wanted to parse the modbus sample config that was exported with Telegraf config create. To edit this in general way.

Expected behavior

I could parse the toml input config file without any errors.

Actual behavior

I tried to parse the config file. But add the metric section from the modbus input plugin. I get the error of a malformed toml syntax. This error appears on line 62 col 68 in that comes from the file "telegraf/plugins/modbus/sample_metric.conf".
The toml lint checker also says the there is an error. For me its seemed like a typo. Because there is only an ',' to much.

Additional info

No response

@cwedel cwedel added the feature request Requests for new plugin and for new features to existing plugins label Feb 22, 2024
powersj added a commit to powersj/telegraf that referenced this issue Feb 22, 2024
@powersj
Copy link
Contributor

powersj commented Feb 22, 2024

Thanks for the catch, I've put up #14883 to remove this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants