Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags no longer passed in due to change in Client #18

Closed
shortjared opened this issue Jun 21, 2015 · 2 comments · Fixed by influxdata/influxdb#3131
Closed

Tags no longer passed in due to change in Client #18

shortjared opened this issue Jun 21, 2015 · 2 comments · Fixed by influxdata/influxdb#3131

Comments

@shortjared
Copy link

I was experimenting with Telegraf, and I am pretty impressed with the ease of getting it setup and the potential for adding plugins. That said, I noticed that Tags don't seem to be passed at the point level. Not even the default "host" as I would have expected after finding issue #4 .

I think I tracked down the cause.

It looks like a recent change in the influxdb client ( influxdata/influxdb@e6c36d5 ) has made it so that passing common parameters at the batch level is no longer allowed.

If we look at the agent.go code, it appears that the "Tags" were passed at the top of the batch level and expected to be inherited down through the "sub" points. This seems to be leveraging the now removed common batch parameters functionality.

    close(points)

    var acc BatchPoints
    acc.Tags = a.Config.Tags
    acc.Time = time.Now()
    acc.Database = a.Config.Database

    for sub := range points {
        acc.Points = append(acc.Points, sub.Points...)
    }

I am not familiar enough with Go to effectively fix and properly add unit testing, but hopefully this is enough for someone to jump in and take it from here.

@dever860
Copy link

+1

@mgresser
Copy link
Contributor

+1 Also seeing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants