Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

input hddtemp: Strange data? Why not just use value? #1904

Closed
jonaz opened this issue Oct 16, 2016 · 2 comments · Fixed by #1905
Closed

input hddtemp: Strange data? Why not just use value? #1904

jonaz opened this issue Oct 16, 2016 · 2 comments · Fixed by #1905
Assignees
@sparrc
Milestone
1.2.0

Comments

@jonaz
Copy link
Contributor

jonaz commented Oct 16, 2016

Bug report

Relevant telegraf.conf:

[[inputs.hddtemp]]
address = "127.0.0.1:7634"
devices = ["*"]

System info:

Telegraf - version 1.0.1
ubuntu 14.04

Steps to reproduce:

  1. Just run hddtemp input

Expected behavior:

The temperature should be in the value field and not a new field for each disk?

Actual behavior:

2016-10-16-110545_1229x455_scrot
@jonaz
Copy link
Contributor Author

jonaz commented Oct 16, 2016 •
edited
Loading

cc @mendelgusmao
If none kan motivate current implementation i can create PR to move it to value.

@jonaz jonaz mentioned this issue Oct 16, 2016
Merged
3 tasks
@mendelgusmao
Copy link
Contributor

Sorry for not noticing this before. It was my first PR. hddtemp's plugin implementation was based off of sensors plugin.

I agree with the changes proposed by @jonaz and am willing to accept a PR at MendelGusmao/go-hddtemp.

@sparrc sparrc added this to the 1.2.0 milestone Nov 3, 2016
jonaz added a commit to jonaz/telegraf that referenced this issue Dec 13, 2016
@jonaz
Change hddtemp to always put temperature in temperature field
368425d 
Added unit tests for the changes

Fixes influxdata#1904
sparrc pushed a commit that referenced this issue Dec 13, 2016
@jonaz @sparrc
Change hddtemp to always put temperature in temperature field (#1905)
b4f9bc8 
Added unit tests for the changes

Fixes #1904
njwhite pushed a commit to njwhite/telegraf that referenced this issue Jan 31, 2017
@jonaz
Change hddtemp to always put temperature in temperature field (influx…
b8badeb 
…data#1905)

Added unit tests for the changes

Fixes influxdata#1904
maxunt pushed a commit that referenced this issue Jun 26, 2018
@jonaz @sparrc
Change hddtemp to always put temperature in temperature field (#1905)
74d8aef 
Added unit tests for the changes

Fixes #1904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sparrc sparrc

Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Change hddtemp to always put temperature in value field jonaz/telegraf
3 participants
@mendelgusmao @jonaz @sparrc