Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statsd metrics not isolated per plugin #1975

Closed
kostasb opened this issue Oct 31, 2016 · 0 comments · Fixed by #2185
Closed

Statsd metrics not isolated per plugin #1975

kostasb opened this issue Oct 31, 2016 · 0 comments · Fixed by #2185
Assignees
@sparrc
Labels
bug unexpected problem or unintended behavior
Milestone
1.2.0

Comments

@kostasb
Copy link

kostasb commented Oct 31, 2016

Running 2 statsd input plugins:

 [[inputs.statsd]]
   name_prefix = "gauges_"
   service_address = ":8125"
   metric_separator = "_"
   templates = ["measurement.atag"]
   allowed_pending_messages = 10000

 [[inputs.statsd]]
   name_prefix = "counters_"
   service_address = ":8126"
   metric_separator = "_"
   templates = ["measurement.atag"]
   allowed_pending_messages = 10000

Submit a single metric to one of the inputs, e.g. on port 8125:

echo "a.b:100|c" | nc -u localhost 8125

This results in two output metrics, both prefixes applied.

counters_a,atag=b,host=kubuntu,metric_type=counter value=100i 1477910760000000000
gauges_a,atag=b,host=kubuntu,metric_type=counter value=100i 1477910760000000000

Tested on the nightly build.
@kostasb kostasb added the bug unexpected problem or unintended behavior label Oct 31, 2016
@sparrc sparrc added this to the 1.2.0 milestone Nov 2, 2016
@sparrc sparrc mentioned this issue Nov 29, 2016
Closed
sparrc added a commit that referenced this issue Dec 20, 2016
@sparrc
Do not create a global statsd "previous instance"
200237a 
this basically reverts #887

at some point we might want to do some special handling of reloading
plugins and keeping their state intact, but that will need to be done at
a higher level, and in a way that is thread-safe for multiple input
plugins of the same type.

Unfortunately this is a rather large feature that will not have a quick
fix available for it.

fixes #1975
fixes #2102
@sparrc sparrc mentioned this issue Dec 20, 2016
Merged
3 tasks
njwhite pushed a commit to njwhite/telegraf that referenced this issue Jan 31, 2017
@sparrc
Do not create a global statsd "previous instance"
505b183 
this basically reverts influxdata#887

at some point we might want to do some special handling of reloading
plugins and keeping their state intact, but that will need to be done at
a higher level, and in a way that is thread-safe for multiple input
plugins of the same type.

Unfortunately this is a rather large feature that will not have a quick
fix available for it.

fixes influxdata#1975
fixes influxdata#2102
maxunt pushed a commit that referenced this issue Jun 26, 2018
@sparrc
Do not create a global statsd "previous instance"
73acd11 
this basically reverts #887

at some point we might want to do some special handling of reloading
plugins and keeping their state intact, but that will need to be done at
a higher level, and in a way that is thread-safe for multiple input
plugins of the same type.

Unfortunately this is a rather large feature that will not have a quick
fix available for it.

fixes #1975
fixes #2102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sparrc sparrc

Labels
bug unexpected problem or unintended behavior
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Do not create a global statsd "previous instance" influxdata/telegraf
3 participants
@sparrc @121watts @kostasb