-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support packet size in the ping plugin #2830
Comments
I am leaning towards letting the user provide general args to their ping executable. |
My own personal thoughts, it would be nice if we weren't calling out to an external utility. It would be nice if telegraf itself would do the ping. There are 2 ways this could be accomplished. By using CAP_NET_RAW, or ICMP sockets, and then fallback to |
What are the drawbacks of the setcap approach? I don't really have a problem with requiring the user to do this before using it. How would things work on BSD, Mac, Windows? Is setcap sufficient if you are using apparmor, selinux, etc? We must have thought about this before: https://github.com/sparrc/go-ping |
I opened a new issue to continue the discussion so that I don't hijack this one. #2833 |
Feature Request: Support "packet size" option.
Please, add packet size option. We have no problem with small packets in our network. But sometimes we have problems with packets > 1200 bytes.
The text was updated successfully, but these errors were encountered: