Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support packet size in the ping plugin #2830

Closed
l0rda opened this issue May 19, 2017 · 4 comments · Fixed by #4703
Closed

Support packet size in the ping plugin #2830

l0rda opened this issue May 19, 2017 · 4 comments · Fixed by #4703
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Milestone
1.9.0

Comments

@l0rda
Copy link

l0rda commented May 19, 2017

Feature Request: Support "packet size" option.

Please, add packet size option. We have no problem with small packets in our network. But sometimes we have problems with packets > 1200 bytes.
@danielnelson danielnelson added this to the 1.4.0 milestone May 19, 2017
@danielnelson
Copy link
Contributor

I am leaning towards letting the user provide general args to their ping executable.

@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label May 19, 2017
@phemmer
Copy link
Contributor

phemmer commented May 19, 2017

My own personal thoughts, it would be nice if we weren't calling out to an external utility. It would be nice if telegraf itself would do the ping. There are 2 ways this could be accomplished. By using CAP_NET_RAW, or ICMP sockets, and then fallback to ping if neither is available. While this is a completely separate issue, allowing specifying arguments to the ping executable wouldn't be very interoperable. A specific ping_size parameter would apply to both.

@danielnelson
Copy link
Contributor

What are the drawbacks of the setcap approach? I don't really have a problem with requiring the user to do this before using it. How would things work on BSD, Mac, Windows? Is setcap sufficient if you are using apparmor, selinux, etc?

We must have thought about this before: https://github.com/sparrc/go-ping

@phemmer phemmer mentioned this issue May 20, 2017
Closed
@phemmer
Copy link
Contributor

phemmer commented May 20, 2017

I opened a new issue to continue the discussion so that I don't hijack this one. #2833

@danielnelson danielnelson modified the milestones: 1.4.0, 1.5.0 Aug 14, 2017
@danielnelson danielnelson modified the milestones: 1.5.0, 1.6.0 Nov 30, 2017
@russorat russorat modified the milestones: 1.6.0, 1.7.0 Jan 26, 2018
@danielnelson danielnelson modified the milestones: 1.7.0, 1.8.0 Jun 3, 2018
@russorat russorat modified the milestones: 1.8.0, 1.9.0 Sep 4, 2018
@Jaeyo Jaeyo mentioned this issue Sep 27, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

Support IPv6 in the ping plugin Jaeyo/telegraf
4 participants
@danielnelson @phemmer @l0rda @russorat