Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update OpenTelemetry plugins #10010

Merged
merged 1 commit into from
Nov 8, 2021
Merged

chore: update OpenTelemetry plugins #10010

merged 1 commit into from
Nov 8, 2021

Conversation

jacobmarble
Copy link
Member

Required for all PRs:

This is a simple dependency update.

@telegraf-tiger
Copy link
Contributor

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1% increase)

📦 Looks like new artifacts were built from this PR.

Expand this list to get them here! 🐯

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm freebsd_amd64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_armv7.tar.gz
armhf.deb i386.rpm freebsd_i386.tar.gz
i386.deb ppc64le.rpm linux_amd64.tar.gz
mips.deb s390x.rpm linux_arm64.tar.gz
mipsel.deb x86_64.rpm linux_armel.tar.gz
ppc64el.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

srebhan
srebhan reviewed Oct 28, 2021
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobmarble thanks for the update making the code cleaner. I only have a question regarding the trash variable declarations that you use: Why are those needed?

plugins/inputs/opentelemetry/grpc_services.go Show resolved Hide resolved
plugins/inputs/opentelemetry/grpc_services.go Show resolved Hide resolved
plugins/inputs/opentelemetry/grpc_services.go Show resolved Hide resolved
@srebhan srebhan self-assigned this Oct 28, 2021
@srebhan srebhan added area/telemetry All about OpenTelemetry and other telemetry variants dependencies Pull requests that update a dependency file feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Oct 28, 2021
srebhan
srebhan approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @jacobmarble for the cleanup.

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 3, 2021
@powersj powersj merged commit 9871b67 into influxdata:master Nov 8, 2021
powersj pushed a commit that referenced this pull request Nov 17, 2021
@jacobmarble @powersj
chore: update OpenTelemetry plugins (#10010)
7579dd0 
(cherry picked from commit 9871b67)
VladislavSenkevich pushed a commit to gwos/telegraf that referenced this pull request Nov 23, 2021
@jacobmarble
chore: update OpenTelemetry plugins (influxdata#10010)
393fedc
@sspaink sspaink mentioned this pull request Dec 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
area/telemetry All about OpenTelemetry and other telemetry variants dependencies Pull requests that update a dependency file feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacobmarble @powersj @srebhan