fix: update influxdb input schema documentation #10029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powersj
approved these changes
Oct 29, 2021
powersj
added
the
ready for final review
|
😄 This pull request doesn't change the Telegraf binary size 📦 Looks like new artifacts were built from this PR. Expand this list to get them here! 🐯Artifact URLs |
reimda
reviewed
Nov 1, 2021
Comment on lines
-56
to
-81
| - heap_inuse: The number of bytes in in-use spans. | ||
| - heap_released: The number of bytes of physical memory returned to the OS. | ||
| - mspan_inuse: The number of bytes in in-use mspans. | ||
| - total_alloc: The cumulative bytes allocated for heap objects. | ||
| - sys: The total number of bytes of memory obtained from the OS. Measures the virtual address space reserved by the Go runtime for the heap, stacks, and other internal data structures. | ||
| - mallocs: The total number of heap objects allocated. (The total number of live objects are frees.) | ||
| - frees: The cumulative number of freed (live) heap objects. | ||
| - heap_idle: The number of bytes of idle heap objects. | ||
| - pause_total_ns: The total time garbage collection cycles are paused in nanoseconds. | ||
| - lookups: The number of pointer lookups performed by the runtime. Primarily useful for debugging runtime internals. | ||
| - heap_sys: The number of bytes of heap memory obtained from the OS. Measures the amount of virtual address space reserved for the heap. | ||
| - mcache_sys: The bytes of memory obtained from the OS for mcache structures. | ||
| - next_gc: The target heap size of the next garbage collection cycle. | ||
| - gc_cpu_fraction: The fraction of CPU time used by the garbage collection cycle. | ||
| - other_sys: The number of bytes of memory used other than heap_sys, stacks_sys, mspan_sys, mcache_sys, buckhash_sys, and gc_sys. | ||
| - alloc: The currently allocated number of bytes of heap objects. | ||
| - stack_inuse: The number of bytes in in-use stacks. | ||
| - stack_sys: The total number of bytes of memory obtained from the stack in use. | ||
| - buck_hash_sys: The bytes of memory in profiling bucket hash tables. | ||
| - gc_sys: The bytes of memory in garbage collection metadata. | ||
| - num_gc: The number of completed garbage collection cycles. | ||
| - heap_alloc: The size, in bytes, of all heap objects. | ||
| - heap_objects: The number of allocated heap objects. | ||
| - mspan_sys: The bytes of memory obtained from the OS for mspan. | ||
| - mcache_inuse: The bytes of allocated mcache structures. | ||
| - last_gc: Time the last garbage collection finished, as nanoseconds since 1970 (the UNIX epoch). |
There was a problem hiding this comment.
These were snake_case before but switched to camelCase. Was this a doc error that is being corrected or are they supposed to be snake_case?
There was a problem hiding this comment.
@reimda, I updated these to the most recent version of InfluxDB 1.x (1.8). It could be that they were snake_case in previous versions of InfluxDB when this input was originally developed, but they have since changed to camelCase.
powersj
pushed a commit
that referenced
this pull request
Nov 17, 2021
(cherry picked from commit 934db67)
VladislavSenkevich
pushed a commit
to gwos/telegraf
that referenced
this pull request
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes influxdata/DAR#232
Updated the metrics and descriptions returned by the InfluxDB input plugin.