Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not build modbus on openbsd #10047

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Nov 2, 2021

This is the remaining plugin that is blocking builds on OpenBSD. The issue is the github.com/grid-x/serial library does not build on OpenBSD. That library is an indirect import, due to github.com/grid-x/modbus. Upgrading modbus does not help the situation as it does not pull in a newer version of the grid-x/serial.

Because this is the only one, I figured it is simpler to stop building this on openbsd until someone comes by with a better solution.

Required for all PRs:

resolves #10034

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Nov 2, 2021
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj for the fix. Code looks good even though I would prefer fixing the underlying library to provide modbus support for OpenBSD... :-)

@srebhan srebhan self-assigned this Nov 3, 2021
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 3, 2021
@sspaink sspaink merged commit ce46506 into influxdata:master Nov 9, 2021
powersj added a commit that referenced this pull request Nov 17, 2021
VladislavSenkevich pushed a commit to gwos/telegraf that referenced this pull request Nov 23, 2021
@geowiwi
Copy link
Contributor

geowiwi commented Jan 5, 2022

OpenBSD support in the underlying library was fixed in:

grid-x/serial#5

Associated pull request: #10385

@powersj powersj deleted the fix/modbus-openbsd branch January 23, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update inputs.modbus serial module dependency to unbreak OpenBSD
4 participants