Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update BurntSushi/toml for hex config support #10089

Merged
merged 3 commits into from
Nov 11, 2021

Conversation

DavidBuettner
Copy link
Contributor

@DavidBuettner DavidBuettner commented Nov 10, 2021

  • Updated associated README.md. - Not necessary
  • Wrote appropriate unit tests. - Added to plugins/common/shim/config_test.go
  • Pull request title or commits are in conventional commit format

resolves #10088

Bump up version of BurntSushi/toml to v0.4.1

Local tests:

  • make check and make test run successfully
  • Starting the docker containers and running make test-integration runs with two failures, which locally on my machine also fail with the current master (i.e. same behavior for BurntSushi/toml v0.3.1 and v0.4.1:
    • FAIL github.com/influxdata/telegraf/plugins/inputs/ping 10.169s
    • FAIL github.com/influxdata/telegraf/plugins/outputs/mongodb 65.052s

Signed-off-by: David Buettner <david.buettner@siemens.com>
@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Nov 10, 2021
Signed-off-by: David Buettner <david.buettner@siemens.com>
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are about 100 commits/3 years between those versions. Lots of tests, lexing, and lint fixes. Issue about leading zero regression. Otherwise no other references to regressions.

+1

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 10, 2021
@DavidBuettner
Copy link
Contributor Author

DavidBuettner commented Nov 10, 2021

Looks like there are about 100 commits/3 years between those versions. Lots of tests, lexing, and lint fixes. Issue about leading zero regression. Otherwise no other references to regressions.

+1

Just added test to parse a hex value into plugins/common/shim/config_test.go - works for me locally (and breaks for me locally with the old BurntSushi/toml version). Hope this is a good place for the test. (@powersj )

Copy link
Contributor

@MyaLongmire MyaLongmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@MyaLongmire MyaLongmire merged commit b9c444b into influxdata:master Nov 11, 2021
@DavidBuettner DavidBuettner deleted the bug/ConfigTomlHex branch November 12, 2021 08:06
powersj pushed a commit that referenced this pull request Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hex values not supported by currently used https://github.com/BurntSushi/toml/
3 participants