Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support darwin arm64 #10239

Merged
merged 11 commits into from
Dec 15, 2021
Merged

feat: support darwin arm64 #10239

merged 11 commits into from
Dec 15, 2021

Conversation

MyaLongmire
Copy link
Contributor

Required for all PRs:

resolves #8693

Add darwin arm64 to the makefile and circle ci

@MyaLongmire MyaLongmire added the wip label Dec 7, 2021
@MyaLongmire MyaLongmire marked this pull request as ready for review December 7, 2021 22:56
@powersj
Copy link
Contributor

powersj commented Dec 7, 2021

This is awesome! Can you please also update the docs/NIGHTLIES.md file to include downloads for both, please?

I'll go try out the arm64 artifacts from this MP on my M1.

@powersj
Copy link
Contributor

powersj commented Dec 7, 2021

The CircleCI artifact looks good. It is not signed, so I do get a prompt about not running it, but I can bypass that. When we do our release we will want to ensure that we sign both the amd64 and arm64 binaries.

@MyaLongmire
Copy link
Contributor Author

This is awesome! Can you please also update the docs/NIGHTLIES.md file to include downloads for both, please?

Done! :)

It is not signed, so I do get a prompt about not running it

Is there anything I need to do about that here or just during the release?

@powersj
Copy link
Contributor

powersj commented Dec 7, 2021

Is there anything I need to do about that here or just during the release?

For the release, the only thing here that will need updating is scripts/mac-signing.sh. We would need it to sign both files. Right now it is hard coded for darwin_amd64.tar only.

@MyaLongmire
Copy link
Contributor Author

For the release, the only thing here that will need updating is scripts/mac-signing.sh. We would need it to sign both files. Right now it is hard coded for darwin_amd64.tar only.

Now it is a loop that goes over both files.

scripts/mac-signing.sh Outdated Show resolved Hide resolved
docs/NIGHTLIES.md Outdated Show resolved Hide resolved
@powersj
Copy link
Contributor

powersj commented Dec 8, 2021

/github/workspace/docs/NIGHTLIES.md:17:151 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
/github/workspace/docs/NIGHTLIES.md:22:158 MD047/single-trailing-newline Files should end with a single newline character

The file looks better, but in the preview, the linux_armel.tar.gz file doesn't have a link.

@MyaLongmire
Copy link
Contributor Author

The file looks better, but in the preview, the linux_armel.tar.gz file doesn't have a link.

The h from https was missing 🤦

@MyaLongmire MyaLongmire added ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. and removed wip labels Dec 9, 2021
@powersj
Copy link
Contributor

powersj commented Dec 9, 2021

For any reviewers, we are not merging this until after 1.21 goes out the door.

docs/NIGHTLIES.md Outdated Show resolved Hide resolved
Co-authored-by: Joshua Powers <powersj@influxdata.com>
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Dec 9, 2021

@Hipska Hipska self-requested a review December 14, 2021 09:59
@powersj
Copy link
Contributor

powersj commented Dec 15, 2021

v1.21.0 is out! let's do this!

@powersj powersj merged commit 082c7a5 into master Dec 15, 2021
@powersj powersj deleted the darwin-arm64 branch December 15, 2021 23:27
reimda pushed a commit that referenced this pull request Dec 16, 2021
(cherry picked from commit 082c7a5)
powersj pushed a commit that referenced this pull request Jan 5, 2022
(cherry picked from commit 082c7a5)
powersj pushed a commit to powersj/telegraf that referenced this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have ARM64 Mac OS X release package
2 participants