-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support darwin arm64 #10239
feat: support darwin arm64 #10239
Conversation
This is awesome! Can you please also update the docs/NIGHTLIES.md file to include downloads for both, please? I'll go try out the arm64 artifacts from this MP on my M1. |
The CircleCI artifact looks good. It is not signed, so I do get a prompt about not running it, but I can bypass that. When we do our release we will want to ensure that we sign both the amd64 and arm64 binaries. |
Done! :)
Is there anything I need to do about that here or just during the release? |
For the release, the only thing here that will need updating is |
Now it is a loop that goes over both files. |
The file looks better, but in the preview, the |
The h from https was missing 🤦 |
For any reviewers, we are not merging this until after 1.21 goes out the door. |
Co-authored-by: Joshua Powers <powersj@influxdata.com>
📦 Looks like new artifacts were built from this PR. Expand this list to get them here ! 🐯Artifact URLs |
v1.21.0 is out! let's do this! |
(cherry picked from commit 082c7a5)
(cherry picked from commit 082c7a5)
Required for all PRs:
resolves #8693
Add darwin arm64 to the makefile and circle ci