-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix panic in parsers due to missing Log #10288
Conversation
Thanks so much for the pull request! |
!signed-cla |
Thanks so much for the pull request! |
👍 This pull request doesn't change the Telegraf binary size 📦 Looks like new artifacts were built from this PR. Expand this list to get them here ! 🐯Artifact URLs |
!signed-cla |
Thanks so much for the pull request! |
I tested this PR and it fixed #10285 for me. |
In #10286 I provided a Dockerfile that reproduced the issue. With the artifact provided on this PR for RPM-based x86_64 systems the issue seems to be solved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick fix!
@srebhan when do you think this will be in a new release? |
@tarjei there will be a 1.21.1 release, not exactly sure when... |
@tarjei oh it's already on the Download page... :-) |
resolves #10285
resolves #10286
Plugins using the SetParserFunc do not initialize the parsers'
Log
field properly (nor do they callInit()
). This PR fixes the resulting panic by doing the initialization properly.A quick search shows that
file
,tail
anddirectory_monitor
seem to be hit by this bug.