fix: do not require networking during tests #10321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a couple of tests that get run which reach out to external network devices. Unit tests should not depend on functional networking or be reaching out to random servers. The DNS server is somewhat understandable, but the SNMP server is an unknown system that is not owned by the development team. Fixes: influxdata#9894
srebhan
added
the
ready for final review
|
📦 Looks like new artifacts were built from this PR. Expand this list to get them here ! 🐯Artifact URLs |
MyaLongmire
approved these changes
Dec 21, 2021
|
I don’t think those snmp checks make an actual connection? |
powersj
added a commit
that referenced
this pull request
Jan 5, 2022
(cherry picked from commit 6a1442f)
|
@powersj could you elaborate on skipping the snmp plugin tests? |
You can try this out by turning off networking on your system and run those tests. You will see that they attempt to make a connection to |
|
And the tests fail in that situation? |
|
Yes, the tests fail when the user has no networking. |
|
Okay, fine then! 👍 |
powersj
added a commit
to powersj/telegraf
that referenced
this pull request
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of tests that get run that reach out to external
network devices. Unit tests should not depend on functional networking
or be reaching out to random servers. The DNS server is somewhat
understandable, but the SNMP server is an unknown system that is not
owned by the development team.
Fixes: #9894