Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update djherbis/times and fix dependabot #10332

Merged
merged 2 commits into from
Dec 22, 2021
Merged

fix: update djherbis/times and fix dependabot #10332

merged 2 commits into from
Dec 22, 2021

Conversation

sspaink
Copy link
Contributor

@sspaink sspaink commented Dec 22, 2021

resolves #10327

Newest version of djherbis/times doesn't seem to be under gopkg.in anymore, to get to the latest version v1.5.0 the import needed to be changed to the github.com url. This should also resolve the dependabot issue that is blocking it from automatically updating PRs.

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Dec 22, 2021
@telegraf-tiger
Copy link
Contributor

👍 This pull request doesn't change the Telegraf binary size

📦 Looks like new artifacts were built from this PR.

Expand this list to get them here ! 🐯

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb s390x.rpm linux_amd64.tar.gz
mipsel.deb x86_64.rpm linux_arm64.tar.gz
ppc64el.deb linux_armel.tar.gz
s390x.deb linux_armhf.tar.gz
linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

srebhan
srebhan approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @sspaink!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 22, 2021
@srebhan srebhan self-assigned this Dec 22, 2021
@sspaink sspaink merged commit da1ddd5 into master Dec 22, 2021
@sspaink sspaink deleted the fixdependabot branch December 22, 2021 19:30
@sspaink sspaink mentioned this pull request Dec 23, 2021
Merged
powersj pushed a commit that referenced this pull request Jan 5, 2022
@sspaink @powersj
fix: update djherbis/times and fix dependabot (#10332)
ff4cc03 
(cherry picked from commit da1ddd5)
powersj pushed a commit to powersj/telegraf that referenced this pull request Jan 21, 2022
@sspaink @powersj
fix: update djherbis/times and fix dependabot (influxdata#10332)
5073adf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with Dependabot
3 participants
@sspaink @powersj @srebhan