Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: document deprecation of timeout #10373

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Conversation

MyaLongmire
Copy link
Contributor

Required for all PRs:

resolves #

Timeout was deprecated in 1.20.0 as we now call gosmi instead of snmptranslate but it was not documented.

@powersj powersj merged commit d8cc355 into master Jan 4, 2022
@powersj powersj deleted the snmp-trap-timeout-deprecation branch January 4, 2022 19:46
@srebhan
Copy link
Contributor

srebhan commented Jan 5, 2022

Just as a side note, you could have used the deprecation framework for this by

type SnmpTrap struct {
	ServiceAddress string          `toml:"service_address"`
-	Timeout        config.Duration `toml:"timeout"`
+	Timeout        config.Duration `toml:"timeout" deprecated:"1.20.0;no longer used"`
	Version        string          `toml:"version"`

@MyaLongmire
Copy link
Contributor Author

That is in Thomas' pr here. We just want to note it in the readme in a release before we take his.

powersj pushed a commit that referenced this pull request Jan 5, 2022
nward added a commit to nward/telegraf that referenced this pull request Jan 12, 2022
powersj pushed a commit to powersj/telegraf that referenced this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants