Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: empty import tzdata for Windows binaries #10377

Merged
merged 1 commit into from
Jan 5, 2022
Merged

fix: empty import tzdata for Windows binaries #10377

merged 1 commit into from
Jan 5, 2022

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jan 4, 2022

The telegraf binary currently does not include any timezone data. While
this data is usually readily available in linux systems it is not
available to a go binary in Windows.

Fixes: #8756

@powersj
fix: empty import tzdata for Windows binaries
3e7cf5f 
The telegraf binary currently does not include any timezone data. While
this data is usually readily available in linux systems it is not
available to a go binary in Windows.

Fixes: influxdata#8756
@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Jan 4, 2022
@powersj powersj mentioned this pull request Jan 4, 2022
Closed
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jan 4, 2022

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Looks like new artifacts were built from this PR.

Expand this list to get them here ! 🐯

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@powersj powersj merged commit 078242b into influxdata:master Jan 5, 2022
powersj added a commit that referenced this pull request Jan 5, 2022
@powersj
fix: empty import tzdata for Windows binaries (#10377)
e16c6df 
The telegraf binary currently does not include any timezone data. While
this data is usually readily available in linux systems it is not
available to a go binary in Windows.

Fixes: #8756
(cherry picked from commit 078242b)
powersj added a commit to powersj/telegraf that referenced this pull request Jan 21, 2022
@powersj
fix: empty import tzdata for Windows binaries (influxdata#10377)
d15428a 
The telegraf binary currently does not include any timezone data. While
this data is usually readily available in linux systems it is not
available to a go binary in Windows.

Fixes: influxdata#8756
@powersj powersj deleted the fix/windows-timezone branch January 23, 2022 21:12
@powersj powersj mentioned this pull request Mar 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyaLongmire MyaLongmire MyaLongmire approved these changes

Assignees
No one assigned
Labels
fix pr to fix corresponding bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Telegraf on Windows fails with "File not found"
2 participants
@powersj @MyaLongmire