fix: send actual empty http body when no body is set #10396

powersj · 2022-01-06T22:53:36Z

Even if the http body was empty, the current method will create an
io.ReadCloser and send that to the http request. This was causing a 502
error from a service. Ensuring that the empty body is actually empty
prevents the server side error message.

Add log fixture to tests to aid in debugging.

Fixes: #10386

Even if the http body was empty, the current method will create an io.ReadCloser and send that to the http request. This was causing a 502 error from a service. Ensuring that the empty body is actually empty prevents the server side error message. Add log fixture to tests to aid in debugging. Fixes: influxdata#10386

telegraf-tiger · 2022-01-07T22:31:43Z

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Looks like new artifacts were built from this PR.

Expand this list to get them here ! 🐯

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_i386.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz
		static_linux_amd64.tar.gz

srebhan

Looks good to me @powersj.

(cherry picked from commit 8f02056)

telegraf-tiger bot added the chore label Jan 6, 2022

powersj marked this pull request as draft January 6, 2022 22:54

powersj mentioned this pull request Jan 6, 2022

More flexibility in adding the "Authorization" header for inputs.http plugin #10386

Closed

powersj force-pushed the debug/http branch from 95b2c31 to 6169d93 Compare January 7, 2022 21:20

powersj force-pushed the debug/http branch from f93cc1f to 8eaac3d Compare January 7, 2022 22:15

powersj changed the title ~~chore: debug output for http plugin~~ fix: send actual empty http body when no body is set Jan 10, 2022

powersj marked this pull request as ready for review January 10, 2022 14:30

srebhan approved these changes Jan 11, 2022

View reviewed changes

srebhan self-assigned this Jan 11, 2022

srebhan added fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. and removed chore labels Jan 11, 2022

MyaLongmire approved these changes Jan 11, 2022

View reviewed changes

MyaLongmire merged commit 8f02056 into influxdata:master Jan 11, 2022

powersj added a commit to powersj/telegraf that referenced this pull request Jan 21, 2022

fix: ensure http body is empty (influxdata#10396)

0024236

powersj deleted the debug/http branch January 23, 2022 21:12

reimda pushed a commit that referenced this pull request Jan 27, 2022

fix: ensure http body is empty (#10396)

811f6d3

(cherry picked from commit 8f02056)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: send actual empty http body when no body is set #10396

fix: send actual empty http body when no body is set #10396

powersj commented Jan 6, 2022 •

edited

telegraf-tiger bot commented Jan 7, 2022

Artifact URLs

srebhan left a comment

fix: send actual empty http body when no body is set #10396

fix: send actual empty http body when no body is set #10396

Conversation

powersj commented Jan 6, 2022 • edited

telegraf-tiger bot commented Jan 7, 2022

Artifact URLs

srebhan left a comment

Choose a reason for hiding this comment

powersj commented Jan 6, 2022 •

edited