Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add newline in execd for prometheus parsing #10463

Merged
merged 1 commit into from
Jan 20, 2022
Merged

fix: add newline in execd for prometheus parsing #10463

merged 1 commit into from
Jan 20, 2022

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jan 19, 2022

The Prometheus parser currently will return a text format parsing error
due to an unexpected end of input stream. This is due to there not being
a new line (e.g. \n) at the end of the string. Once added, the execd
works as expected.

Fixes: #10460

@powersj
fix: add newline in execd for prometheus parsing
32ccc88 
The Prometheus parser currently will return a text format parsing error
due to an unexpected end of input stream. This is due to there not being
a new line (e.g. \n) at the end of the string. Once added, the execd
works as expected.

Fixes: influxdata#10460
@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Jan 19, 2022
@powersj powersj mentioned this pull request Jan 19, 2022
Closed
@telegraf-tiger
Copy link
Contributor

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Looks like new artifacts were built from this PR.

Expand this list to get them here ! 🐯

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@powersj powersj marked this pull request as draft January 19, 2022 18:33
@powersj powersj marked this pull request as ready for review January 20, 2022 15:39
@powersj powersj merged commit 61214bd into influxdata:master Jan 20, 2022
powersj added a commit to powersj/telegraf that referenced this pull request Jan 21, 2022
@powersj
fix: add newline in execd for prometheus parsing (influxdata#10463)
8b6a7a6
powersj added a commit to powersj/telegraf that referenced this pull request Jan 21, 2022
@powersj
fix: add newline in execd for prometheus parsing (influxdata#10463)
b7ff5d3
@powersj powersj deleted the fix/prometheus-execd branch January 23, 2022 21:14
reimda pushed a commit that referenced this pull request Jan 27, 2022
@powersj @reimda
fix: add newline in execd for prometheus parsing (#10463)
e06cc20 
(cherry picked from commit 61214bd)
arstercz added a commit to arstercz/telegraf that referenced this pull request Feb 9, 2022
@arstercz
merge influxdata#10463, add newline in execd for prometheus parsing
58885e3
arstercz added a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@arstercz
merge influxdata#10463, add newline in execd for prometheus parsing
d54ef06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyaLongmire MyaLongmire MyaLongmire approved these changes

Assignees
No one assigned
Labels
fix pr to fix corresponding bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Execd plugin error deal “\n” for data_format prometheus.
2 participants
@powersj @MyaLongmire