Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(persers.nagios): nagios parser now uses real error for logging #10473

Merged
merged 1 commit into from
Jan 20, 2022
Merged

fix(persers.nagios): nagios parser now uses real error for logging #10473

merged 1 commit into from
Jan 20, 2022

Conversation

Sakerdotes
Copy link
Contributor

Required for all PRs:

resolves #10472

The real error will now be returned by the "getExitCode" function instead of an placeholder.
With these changes all real errors message will be written to the log. Problems can be debuged properly.

@Sakerdotes Sakerdotes changed the title nagios parser now uses real error for logging #10472 nagios parser now uses real error for logging Jan 20, 2022
@Sakerdotes Sakerdotes changed the title nagios parser now uses real error for logging fix: nagios parser now uses real error for logging Jan 20, 2022
@Sakerdotes Sakerdotes changed the title fix: nagios parser now uses real error for logging fix(persers.nagios): nagios parser now uses real error for logging Jan 20, 2022
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to make error messages more user-friendly!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 20, 2022
@MyaLongmire MyaLongmire merged commit 83ab2b8 into influxdata:master Jan 20, 2022
@Sakerdotes Sakerdotes deleted the usefullNagiosError branch January 24, 2022 10:31
reimda pushed a commit that referenced this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nagios parser writes no useful log on file permission error
3 participants