Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove verbose logging from disk input plugin #10527

Merged
merged 4 commits into from Feb 22, 2022
Merged

fix: Remove verbose logging from disk input plugin #10527

merged 4 commits into from Feb 22, 2022

Conversation

reimda
Copy link
Contributor

@reimda reimda commented Jan 26, 2022

fixes #10514

@reimda reimda requested a review from srebhan January 26, 2022 18:31
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @reimda thanks for looking into this!
I would love to see set becoming an internal package as it is helpful in many places/plugins. Furthermore, we maybe should limit the error messages to be printed only once? We can use the set again or remove the erroneous mountpoints from the set of processed ones...
What do you think?

plugins/inputs/system/ps.go Outdated Show resolved Hide resolved
plugins/inputs/system/ps.go Show resolved Hide resolved
plugins/inputs/system/ps.go Show resolved Hide resolved
@srebhan srebhan self-assigned this Jan 27, 2022
@srebhan srebhan changed the title Remove verbose logging from disk input plugin fix: Remove verbose logging from disk input plugin Feb 1, 2022
@srebhan
Copy link
Contributor

srebhan commented Feb 1, 2022

@reimda there are some tests failing and they seem to be related... Can you please take a look?

@srebhan
Copy link
Contributor

srebhan commented Feb 16, 2022

@reimda any chance you take a look at the tests?

@reimda
Copy link
Contributor Author

reimda commented Feb 17, 2022

I'm struggling to find how this change causes the failures. I can reproduce them locally but I haven't gotten to the bottom of them yet. Still working on it!

Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @reimda!

@srebhan srebhan added area/system fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/system fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trim down debug messages in disk
4 participants