Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Add deprecation notices to plugin options #10616

Merged
merged 15 commits into from Mar 1, 2022
Merged

style: Add deprecation notices to plugin options #10616

merged 15 commits into from Mar 1, 2022

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented Feb 9, 2022 •
edited

Required for all PRs:

Related to #9478.

Add a proper standardised deprecation notice and remove these options from sample config if not yet done. It also fixes the wrongly deprecation of inputs.http_listener_v2 instead of inputs.http_listener.

Input plugin settings

  • Activemq server and port
  • Aerospike enable_ssl
  • Amqp_consumer url
  • Consul datacentre
  • Docker container_names
  • Docker perdevice
  • Docker total
  • Filecount directory
  • Http_listener_v2 path
  • Http_response address (see also feat: Implement deprecation infrastructure #10200)
  • Httpjson name
  • Influxdb_listener max_line_size
  • Mongodb ssl_enabled and cacerts
  • MQTT Consumer metric_buffer
  • NATS Consumer metric_buffer
  • Nsq_consumer server
  • Openldap ssl and ssl_ca
  • Rabbitmq name
  • Rabbitmq queues
  • Smart path
  • Sqlserver query_version and azuredb
  • Statsd convert_names
  • Statsd parse_data_dog_tags
  • Statsd udp_packet_size
  • Vsphere force_discover_on_init
  • Win_perfcounters PreVistaSupport #10615
  • Zookeeper enable_ssl

Output plugin settings

  • AMQP database and retention_policy
  • AMQP precision
  • AMQP url
  • Influxdb precision
  • Influxdb url
  • Kinesis partitionkey and use_random_partitionkey
  • Librato source_tag
  • Wavefront string_to_number subtable

Common settings

  • flush_buffer_when_full
  • utc
  • Kafka enable_tls
  • TLS ssl_ca, ssl_cert and ssl_key

@telegraf-tiger telegraf-tiger bot added the style label Feb 9, 2022
@Hipska Hipska requested a review from srebhan February 9, 2022 22:47
@Hipska Hipska added area/configuration docs Issues related to Telegraf documentation and configuration descriptions labels Feb 9, 2022
@Hipska Hipska marked this pull request as ready for review February 9, 2022 22:48
@Hipska Hipska requested a review from sjwang90 February 10, 2022 08:32
srebhan
srebhan reviewed Feb 10, 2022
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job @Hipska! Only one comment in the code and a request to add the removal version for MetricBuffer in mqtt_consumer.

config/config.go Show resolved Hide resolved
plugins/outputs/opentsdb/opentsdb.go Show resolved Hide resolved
@srebhan srebhan self-assigned this Feb 10, 2022
@Hipska Hipska mentioned this pull request Feb 15, 2022
Merged
@Hipska Hipska requested a review from srebhan February 15, 2022 17:08
srebhan
srebhan approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for this epic effort @Hipska!

@Hipska Hipska added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 16, 2022
@Hipska Hipska requested a review from powersj February 25, 2022 16:46
@Hipska Hipska requested a review from reimda February 25, 2022 16:47
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

powersj
powersj approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to go through all of these @Hipska!

@powersj powersj merged commit a4f6b27 into influxdata:master Mar 1, 2022
@Hipska Hipska deleted the feature/deprecation-warnings branch March 2, 2022 05:38
MyaLongmire pushed a commit that referenced this pull request Jul 6, 2022
@Hipska @MyaLongmire
style: Add deprecation notices to plugin options (#10616)
64c391a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@powersj powersj powersj approved these changes

@sjwang90 sjwang90 Awaiting requested review from sjwang90

@reimda reimda Awaiting requested review from reimda

Assignees

@srebhan srebhan

Labels
area/configuration docs Issues related to Telegraf documentation and configuration descriptions ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Hipska @reimda @powersj @srebhan