Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix slow running intel-pmu test #10859

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Mar 21, 2022

The makeEvents call is very expensive in terms of both memory usage and
compute time. In order to reduce pressure on a system during tests, this
reduces the number of events, but increases the number of total cores.

The makeEvents call is very expensive in terms of both memory usage and
compute time. In order to reduce pressure on a system during tests, this
reduces the number of events, but increases the number of total cores.
@telegraf-tiger telegraf-tiger bot added the chore label Mar 21, 2022
@sspaink
Copy link
Contributor

sspaink commented Mar 21, 2022

This seems fine, I don't have a lot of knowledge about this. I assume we don't need a test for large number of events?

@powersj
Copy link
Contributor Author

powersj commented Mar 22, 2022

This seems fine, I don't have a lot of knowledge about this. I assume we don't need a test for large number of events?

Looked at the functions called by the test, the only thing we are testing with a large number of events is a for loop in estimateCoresFd and some math in multiplyAndAdd. The math is using uint64 and has checks if the value overflows, but this was not testing that anyway.

@powersj powersj merged commit c2277fa into influxdata:master Mar 24, 2022
@powersj powersj deleted the chore/intel-pmu-long-test branch March 24, 2022 17:55
MyaLongmire pushed a commit that referenced this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants