fix: redundant zfs pool tag #10871
Merged
fix: redundant zfs pool tag #10871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a ZFS pool has multiple datasets it will show up in the ZFS pool list that Telegraf maintains. When trying to produce the ZFS pools tag this will result in a pool name showing up more than once. This creates a unique set of pool names for the tag. Fixes: influxdata#10837
aaronjwood
reviewed
Mar 22, 2022
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
MyaLongmire
approved these changes
Mar 24, 2022
powersj
added
the
ready for final review
reimda
suggested changes
Mar 24, 2022
@reimda Test case added |
Hipska
approved these changes
Mar 25, 2022
reimda
approved these changes
Mar 29, 2022
MyaLongmire
pushed a commit
that referenced
this pull request
Apr 6, 2022
(cherry picked from commit b9151ff)
MyaLongmire
pushed a commit
that referenced
this pull request
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a ZFS pool has multiple datasets it will show up in the ZFS pool list
that Telegraf maintains. When trying to produce the ZFS pools tag this
will result in a pool name showing up more than once. This creates a
unique set of pool names for the tag.
Fixes: #10837