fix: default value for logfile rotation interval #10883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyaLongmire
approved these changes
Mar 24, 2022
The unit of 'd' is not a valid time.Duration unit. Due to the more strict parsing of durations, this is now correctly failing. Previously using a value of '1d' would fail silently. If a user wishes to use a value of days, they need to convert to hours and use '24h' for example of one day. Fixes: influxdata#10882
powersj
force-pushed
the
fix/log-rotation-default
branch
from
095def4
to
3693d42
Compare
|
Updated PR to allow the previous default, but will continue to fail on any other hour-based duration. |
powersj
added
the
ready for final review
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
reimda
approved these changes
Mar 29, 2022
MyaLongmire
pushed a commit
that referenced
this pull request
Apr 6, 2022
(cherry picked from commit fba9769)
MyaLongmire
pushed a commit
that referenced
this pull request
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit of 'd' is not a valid time.Duration unit. Due to the more
strict parsing of durations, this is now correctly failing. Previously
using a value of '1d' would fail silently. If a user wishes to use a
value of days, they need to convert to hours and use '24h' for example
of one day.
Fixes: #10882