Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update starlark 7a1108eaa012->d1966c6b9fcd #10940

Merged
merged 3 commits into from
Apr 12, 2022
Merged

fix: update starlark 7a1108eaa012->d1966c6b9fcd #10940

merged 3 commits into from
Apr 12, 2022

Conversation

sspaink
Copy link
Contributor

@sspaink sspaink commented Apr 5, 2022

resolve: #10828

Updating go.starlark.net to latest version, the project doesn't use official releases but we are using the latest commit. As suggested by @Hipska updated the spec as well to point to the commit instead of master.

@Hipska could you test out this change? thanks!

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Apr 5, 2022
Hipska
Hipska suggested changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@Hipska Hipska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only change the url for all references..

plugins/processors/starlark/README.md Outdated Show resolved Hide resolved
plugins/aggregators/starlark/README.md Outdated Show resolved Hide resolved
@Hipska Hipska added docs Issues related to Telegraf documentation and configuration descriptions dependencies Pull requests that update a dependency file ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Apr 6, 2022
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Apr 6, 2022

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@powersj powersj merged commit b139ee7 into master Apr 12, 2022
@powersj powersj deleted the updatestarlark branch April 12, 2022 13:54
sspaink added a commit that referenced this pull request Apr 25, 2022
@sspaink
fix: update starlark 7a1108eaa012->d1966c6b9fcd (#10940)
bfcefd5 
(cherry picked from commit b139ee7)
MyaLongmire pushed a commit that referenced this pull request Jul 6, 2022
@sspaink @MyaLongmire
fix: update starlark 7a1108eaa012->d1966c6b9fcd (#10940)
1735d1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hipska Hipska Hipska approved these changes

@powersj powersj powersj approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file docs Issues related to Telegraf documentation and configuration descriptions fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Starlark spec
3 participants
@sspaink @Hipska @powersj