Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor testcontainer port lookup #11198

Merged
merged 3 commits into from
May 27, 2022
Merged

test: refactor testcontainer port lookup #11198

merged 3 commits into from
May 27, 2022

Commits on May 27, 2022

  1. test: refactor testcontainer port lookup 

    Containers have at least three options when it comes to specifying the
port a container uses: 80, 80:80, 80/[tcp|udp]. The original logic was
naive and assumed only the first option would ever be used and only one
port was ever cared about.

The new mechanism creates a lookup table for easy use in tests while
also allowing for all the formats above.
    @powersj
    powersj committed May 27, 2022
    Configuration menu
    Copy the full SHA
    0541023 View commit details
    Browse the repository at this point in the history

  2. skip container test in short mode

    @powersj
    powersj committed May 27, 2022
    Configuration menu
    Copy the full SHA
    b1f92f6 View commit details
    Browse the repository at this point in the history

  3. remove logging code as it has race issues

    @powersj
    powersj committed May 27, 2022
    Configuration menu
    Copy the full SHA
    d83aed8 View commit details
    Browse the repository at this point in the history