Output stats to the Instrumental TCP Collector #1139
Conversation
| outputs.Add("instrumental", func() telegraf.Output { | ||
| return &Instrumental{ | ||
| Host: DefaultHost, | ||
| Template: graphite.DEFAULT_TEMPLATE, |
There was a problem hiding this comment.
I wasn't sure what the best way to provide default values is here. Does this get over-written by the Config parsing or does any already-set value take precedence?
There was a problem hiding this comment.
this will get overwritten by the config file parsing
|
Improvements made. |
|
@jasonroelofs sorry about that, we had a problem with our CI script, please rebase and try pushing again |
|
@sparrc All good. Rebased and green again. |
| case "histogram": | ||
| metricType = "increment" | ||
| case "set": | ||
| metricType = "gauge_absolute" |
There was a problem hiding this comment.
gauge_absolute is deprecated and is now just an alias for gauge, you should use gauge for set.
|
@mediocretes Thanks for the feedback. I believe I've addressed these issues. I'm also now checking for stats with characters Instrumental will not accept to help protect against sending bad stats. |
|
Looks good. For name validation, you may find There's still a mention of gauge_absolute in the readme, too, I must have skipped over it last time I reviewed. |
This plugin adds support for the Instrumental stats gathering, graphing, and alerting service. It provides metrics very close to the Graphite formula with some small tweaks.
Documentation for Instrumental's collector here: https://instrumentalapp.com/docs/tcp-collector