chore: Using Windows, add exe extension to tools

[sspaink]

When building Telegraf on a Windows machine, the new tools were being built without exe extension causing the following error:

plugins\inputs\wireguard\wireguard.go:1: running "../../../tools/readme_config_includer/generator": exec: "H:\\Sandbox\\telegraf\\tools\\readme_config_includer\\generator": file does not exist for each plugin

Updated the makefile to add exe extension if GOOS is set to windows.

[powersj]

Thank you! This will fix 1 of the 3 issues in #11609

[barts2108]

Aren't the tools/licence_checker/licence_checker and tools/readme_config_includer/generator supposed to get the .exe extension on windows ? Both the licence_checker (without extension) and generator (without extension) are binary files. If I modify the makefile to use this :

build_tools:
 $(HOSTGO) build -o ./tools/license_checker/license_checker$(EXEEXT) ./tools/license_checker
 $(HOSTGO) build -o ./tools/readme_config_includer/generator$(EXEEXT) ./tools/readme_config_includer/generator.go

with the makefile change mentioned above, and temporary changing HOSTGO to HOSTGO = go
I can build telegraf.exe from a simple cmd.exe and no MingW requirement. However that is building for WIndows on WIndows

[sspaink]

@barts2108 your right the tools do need the .exe extension for windows which is what this pull request will fix. For fixing HOSTGO, I was able to get it working by changing it to HOSTGO := set $(GOOS)= & set $(GOARCH)= & go. The only issue I don't know how to fix is running make clean, which would require using if exists filename del /f filename or if exists folder rmdir /s /q folder but then we need someway to detect what terminal is being used because this would break using bash on windows but I am unable to find anything reliable.

Is using cmd.exe or powershell a requirement for you to develop Telegraf? Otherwise at this point I would rather just update the documentation to say we require MinGW to avoid making the makefile anymore confusing.

[powersj]

HOSTGO := set $(GOOS)= & set $(GOARCH)= & go

nice find!

I don't know how to fix is running make clean

Does power shell have del? We could do del telegraf >nul 2>&1

[barts2108]

Did you notice i added the EXEEXT in those two lines in the build_tools?

cmd or powershe is not a real requirement. However when you just add a requirement for MingW, then please add some documentation too how it must be setup and how it is used. Currently the readme that i used only containse a git clone, a cd and a make instruction. Nothing about environment variables or so.

[barts2108]

HOSTGO := set $(GOOS)= & set $(GOARCH)= & go

nice find!

I don't know how to fix is running make clean

Does power shell have del? We could do del telegraf >nul 2>&1

'rmdir /s /q telegraf'

Edit: i think i forgot the need for some universal commands. But why not using if statements for commands that are different on windows ?

[telegraf-tiger]

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_i386.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz
		static_linux_amd64.tar.gz