-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.opcua): add use regular reads workaround #11630
Conversation
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@me.com>
Have also a look at the |
Good point on the |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 🥳 This pull request decreases the Telegraf binary size by -2.72 % for linux amd64 (new size: 148.5 MB, nightly size 152.6 MB) 📦 Click here to get additional PR build artifactsArtifact URLs |
@R290 is this one ready to review or was there additional development required? Thanks! |
The attached issue contains of 2 parts, and this pull only resolves the second part: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this up. fwiw I think I held off earlier because this was marked draft.
I know this has already been merged, but it has not yet been released. Might I suggest using |
@LarsStegman that's a great idea! Are you willing to put up a pr or should i? |
You can do it if you want 🙂 |
@LarsStegman pr can be found here :) |
Required for all PRs
resolves #11559
Added workaround to use regular reads instead of registered reads.