Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.diskio): Allow selecting devices by ID #11703

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Aug 18, 2022

resolves #11685

This PR will try to resolve all given devices on Linux, i.e. follow the (potential) symlinks of each device to their native "name"/device file which is helpful when specifying disk-ids or uuids. Furthermore, the PR adds the WWID of disks as tag.

Note: All of the above will only work on Linux and only if there are no wildcards used!

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Aug 18, 2022
@powersj
Copy link
Contributor

powersj commented Aug 18, 2022

I like it! What do we need to add the docs?

Copy link
Contributor

@Hipska Hipska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be tested somehow?

@powersj
Copy link
Contributor

powersj commented Sep 21, 2022

@srebhan I think all that is waiting is doc updates and now conflicts resolved

@powersj powersj added the waiting for response waiting for response from contributor label Sep 21, 2022
@srebhan
Copy link
Contributor Author

srebhan commented Sep 27, 2022

@powersj is this what you had in mind?

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Sep 27, 2022
@telegraf-tiger
Copy link
Contributor

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 27, 2022
@sspaink sspaink merged commit 373966b into influxdata:master Sep 28, 2022
dba-leshop pushed a commit to dba-leshop/telegraf that referenced this pull request Oct 30, 2022
@srebhan srebhan deleted the diskio_id branch November 7, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

diskio - specify disk not only by dev but by id as well
4 participants