Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.snmp): Convert enum values #11872

Merged
merged 10 commits into from
Nov 28, 2022
Merged

feat(inputs.snmp): Convert enum values #11872

merged 10 commits into from
Nov 28, 2022

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented Sep 23, 2022 •
edited

Required for all PRs

resolves #6330
resolves #2809

Adds new options enum or enum(1) for the field conversion parameter.

@Hipska Hipska requested a review from reimda September 23, 2022 11:22
@telegraf-tiger telegraf-tiger bot added area/snmp feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Sep 23, 2022
MyaLongmire
MyaLongmire reviewed Oct 11, 2022
View reviewed changes
Copy link
Contributor

@MyaLongmire MyaLongmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hipska the direction of this is great! my only comment so far is to document the conversion options get documented in the readme when you get there :)

@Hipska Hipska marked this pull request as ready for review November 22, 2022 15:04
@Hipska Hipska mentioned this pull request Nov 22, 2022
Closed
@LeadingMoominExpert
Copy link
Contributor

@Hipska good stuff 👏🏻

@Hipska Hipska force-pushed the feat/inputs/snmp/enum branch 2 times, most recently from 6d0d64a to 48c7625 Compare November 23, 2022 16:29
@Hipska Hipska requested review from srebhan and removed request for reimda November 23, 2022 16:50
srebhan
srebhan reviewed Nov 24, 2022
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very nice @Hipska! Just have one request on changing the returned error to a nil explicitly to help the reader to easier catch the non-error nature...

plugins/inputs/snmp/gosmi.go Outdated Show resolved Hide resolved
plugins/inputs/snmp/snmp.go Show resolved Hide resolved
@srebhan srebhan self-assigned this Nov 24, 2022
@Hipska @srebhan
Update nil error return
d1a5088 
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
srebhan
srebhan approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for this contribution @Hipska!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 25, 2022
@srebhan srebhan assigned powersj and unassigned srebhan Nov 25, 2022
@Hipska Hipska mentioned this pull request Nov 25, 2022
Closed
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@powersj powersj merged commit 25154e5 into influxdata:master Nov 28, 2022
@Hipska Hipska deleted the feat/inputs/snmp/enum branch November 28, 2022 15:02
@Hipska Hipska mentioned this pull request Oct 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyaLongmire MyaLongmire MyaLongmire left review comments

@powersj powersj powersj approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@powersj powersj

Labels
area/snmp feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SNMP integer fields are not translated [feature-request] support SNMP enum values
5 participants
@Hipska @LeadingMoominExpert @powersj @MyaLongmire @srebhan