Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(outputs.graylog): Implement connection retries #11950

Merged
merged 19 commits into from
Nov 17, 2022

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Oct 5, 2022

This PR adds code to retry to connect to the given endpoints if connection_retry is set to true. This is helpful in cases where Telegraf is started, but the servers are not up or not reachable yet. The wait-time between retry attempts can be specified via connection_retry_wait_time option.
Please note, Telegraf will try to connect only 3 times if connection_retry = false (default) and will terminate if not successful. To connect forever set connection_retry = true, but be aware that metrics might get lost if the metric buffer overflows before a successful connection was made.

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Oct 5, 2022
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates! couple questions added

plugins/outputs/graylog/graylog.go Outdated Show resolved Hide resolved
plugins/outputs/graylog/graylog.go Show resolved Hide resolved
plugins/outputs/graylog/graylog.go Outdated Show resolved Hide resolved
@srebhan srebhan force-pushed the graylog branch 2 times, most recently from 6588ff9 to b28b704 Compare November 14, 2022 19:29
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates - only comment about the error message

plugins/outputs/graylog/graylog.go Outdated Show resolved Hide resolved
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 16, 2022
@powersj powersj self-assigned this Nov 16, 2022
@telegraf-tiger
Copy link
Contributor

@powersj powersj merged commit bc56233 into influxdata:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants