Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.modbus): add pause after connect config parameter #11983

Merged
merged 3 commits into from
Oct 18, 2022

Conversation

joerg-git
Copy link
Contributor

@joerg-git joerg-git commented Oct 11, 2022

Required for all PRs

resolves feature request #11919

Allows to add a pause (warm-up time) for the slave device after modbus connect. E.g. Huawei solar inverter ethernet dongles need this pause to response the first request.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Oct 11, 2022
@powersj powersj requested a review from srebhan October 11, 2022 17:32
@sspaink sspaink changed the title feat(inputs/modbus): add pause after connect config parameter feat(inputs.modbus): add pause after connect config parameter Oct 11, 2022
@joerg-git joerg-git marked this pull request as draft October 11, 2022 19:17
@joerg-git joerg-git marked this pull request as ready for review October 11, 2022 19:29
@joerg-git
Copy link
Contributor Author

joerg-git commented Oct 11, 2022

Two checks failed:

  1. test-go-windows: FAIL: plugins/inputs/powerdns
  2. make-test-integration: FAIL: TestConnectAndWriteIntegrationX509Auth

My fault?

Edit: all checks passed now.

@sspaink sspaink added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 18, 2022
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to put this up.

I am concerned that this will lead to a lot of "interval took too long" messages if set to high as you mention in the readme.

@powersj powersj merged commit 589447a into influxdata:master Oct 18, 2022
@joerg-git
Copy link
Contributor Author

I am sure that users who need this feature have thought about the duration of Modbus requests beforehand. They will be able to handle it. Thank you for accepting my request.

dba-leshop pushed a commit to dba-leshop/telegraf that referenced this pull request Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants