Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(outputs.event_hubs): Expose max message size batch option #11991

Merged
merged 3 commits into from
Oct 12, 2022

Conversation

R290
Copy link
Contributor

@R290 R290 commented Oct 12, 2022

Required for all PRs

resolves #11990

Made the existing batch option for max message size configurable using the Telegraf config. The default value of 1,000,000 is not suitable for all use cases. The basic event hub tier is 262144 bytes and the other tiers are 1048576 bytes.

@R290 R290 changed the title [outputs.event_hubs] Expose max message size batch option feat:[outputs.event_hubs] Expose max message size batch option Oct 12, 2022
@Hipska Hipska changed the title feat:[outputs.event_hubs] Expose max message size batch option feat(outputs.event_hubs): Expose max message size batch option Oct 12, 2022
@Hipska Hipska added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Oct 12, 2022
Copy link
Contributor

@Hipska Hipska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the default value being 1000000, so I would adapt the README and example config.

@R290
Copy link
Contributor Author

R290 commented Oct 12, 2022

The default setting of 1000000 is hidden in the azure-event-hubs-go library:
https://github.com/Azure/azure-event-hubs-go/blob/d88c0a040d2b0effbb71725fdc90a4793c7840dd/batch.go#L45

@Hipska
Copy link
Contributor

Hipska commented Oct 12, 2022

Aha, okay. In that case I would mention that setting to 0 means using default of 1000000. As this value might change in a future version of the library.

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 12, 2022
@R290 R290 requested a review from Hipska October 12, 2022 14:17
@telegraf-tiger
Copy link
Contributor

@MyaLongmire MyaLongmire merged commit 430ec5b into influxdata:master Oct 12, 2022
dba-leshop pushed a commit to dba-leshop/telegraf that referenced this pull request Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[outputs.event_hubs] Expose MaxMessageSize batch option
4 participants