-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(secretstores): Add support for more plugins #12067
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked only at the changes on top of #11232 as they pertain to usage of the new secrets functionality within telegraf and it LGTM overall. Couple of nitpicks that you're free to ignore. Please think through the one question regarding Get()
that is inline.
82327d0
to
d7a8972
Compare
d7a8972
to
0104aff
Compare
0104aff
to
373607b
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
This PR is based on #11232 and adds secret- and thus secret-store support for more plugins, namely:
inputs.http_response
for username and passwordinputs.kafka_consumer
andoutputs.kafka
viacommon/kafka
inputs.mqtt_consumer
for username and passwordinputs.postgres
foraddress
inputs.postgres_extensible
foraddress
inputs.pgbouncer
foraddress
inputs.snmp_trap
forsec_name
,auth_password
andpriv_password
inputs.sqlserver
when used withauth_method = "connection_string"
(default)inputs.vsphere
for username and password as well as token authentication