Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secretstores): Add support for more plugins #12067

Merged
merged 10 commits into from
Jan 9, 2023

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Oct 20, 2022

This PR is based on #11232 and adds secret- and thus secret-store support for more plugins, namely:

  • inputs.http_response for username and password
  • inputs.kafka_consumer and outputs.kafka via common/kafka
  • inputs.mqtt_consumer for username and password
  • inputs.postgres for address
  • inputs.postgres_extensible for address
  • inputs.pgbouncer for address
  • inputs.snmp_trap for sec_name, auth_password and priv_password
  • inputs.sqlserver when used with auth_method = "connection_string" (default)
  • inputs.vsphere for username and password as well as token authentication

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Oct 20, 2022
@srebhan srebhan marked this pull request as draft October 20, 2022 13:21
@srebhan srebhan mentioned this pull request Oct 20, 2022
3 tasks
Copy link
Contributor

@jdstrand jdstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked only at the changes on top of #11232 as they pertain to usage of the new secrets functionality within telegraf and it LGTM overall. Couple of nitpicks that you're free to ignore. Please think through the one question regarding Get() that is inline.

plugins/common/kafka/sasl.go Show resolved Hide resolved
plugins/inputs/sqlserver/sqlserver.go Show resolved Hide resolved
config/secret.go Outdated Show resolved Hide resolved
@srebhan srebhan force-pushed the secret_store_more_plugins branch 2 times, most recently from 82327d0 to d7a8972 Compare October 20, 2022 14:52
@srebhan srebhan marked this pull request as ready for review December 13, 2022 12:11
@srebhan srebhan marked this pull request as draft December 14, 2022 21:58
@srebhan srebhan marked this pull request as ready for review January 6, 2023 16:45
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 6, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jan 9, 2023

@powersj powersj merged commit 63ab159 into influxdata:master Jan 9, 2023
@srebhan srebhan added this to the v1.26.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/secretstores ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants