Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ethtool): Possibility to skip gathering metrics for downed interfaces #12087

Merged
merged 2 commits into from
Oct 25, 2022
Merged

feat(ethtool): Possibility to skip gathering metrics for downed interfaces #12087

merged 2 commits into from
Oct 25, 2022

Conversation

zak-pawel
Copy link
Collaborator

Some interfaces can expose a few thousands fields. It may not be necessary to gather and expose metrics for interfaces which are not UP.
This PR adds possibility to skip such metrics (but it defaults to exposing them - to be backward compatible):

  ## Specifies plugin behavior regarding metrics for downed interfaces.
  ## Available choices:
  ##   - expose: Telegraf will expose all available metrics for downed interfaces
  ##   - skip: Telegraf will not expose all available metrics for downed interfaces
  # interface_down_metrics = "expose"

Moreover, creation of IncludeExcludeFilter was moved from Gather to Init (input to this filter doesn't change so it makes sense to create it only once).

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Oct 22, 2022
@powersj
Copy link
Contributor

powersj commented Oct 24, 2022

thanks - golang lint seems to be timing out here and there so I kicked it off again

@MyaLongmire MyaLongmire merged commit 284edcc into influxdata:master Oct 25, 2022
dba-leshop pushed a commit to dba-leshop/telegraf that referenced this pull request Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants