Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.netflow): Add netflow plugin #12108

Merged
merged 34 commits into from
Dec 9, 2022
Merged

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Oct 26, 2022

resolves #174

This PR adds a netflow input plugin, acting as a collector for Netflow v5, Netflow v9 and IPFIX data. Additional protocol versions and custom field mappings might be added at a later point.

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Oct 26, 2022
@srebhan srebhan marked this pull request as draft October 26, 2022 16:02
@iec61131
Copy link

Awesome PR! @srebhan Sven , what is the ETA to merge this in master ?

@srebhan
Copy link
Contributor Author

srebhan commented Nov 14, 2022

@iec61131 please discuss this in issue #174. I hope to finish the IPFIX mapping within the next two weeks and hope to get this into 1.25 scheduled for mid of December. Anyway, feedback on the element-id -- field mappings is appreciated!

@srebhan srebhan marked this pull request as ready for review November 23, 2022 20:02
@srebhan srebhan mentioned this pull request Nov 23, 2022
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 7, 2022
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Sven - a few questions and request for additional tests

plugins/inputs/netflow/README.md Outdated Show resolved Hide resolved
plugins/inputs/netflow/README.md Show resolved Hide resolved
plugins/inputs/netflow/README.md Show resolved Hide resolved
plugins/inputs/netflow/README.md Show resolved Hide resolved
plugins/inputs/netflow/README.md Outdated Show resolved Hide resolved
plugins/inputs/netflow/netflow.go Show resolved Hide resolved
plugins/inputs/netflow/netflow_decoder.go Outdated Show resolved Hide resolved
plugins/inputs/netflow/type_conversion.go Show resolved Hide resolved
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Dec 9, 2022

@powersj powersj merged commit 9b33b95 into influxdata:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support netflow data
3 participants