Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.system): collect unique user count logged in #12147

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Nov 2, 2022

fixes: #12144

@telegraf-tiger telegraf-tiger bot added area/system fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Nov 2, 2022
Copy link
Contributor

@MyaLongmire MyaLongmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question. Since you are adding a new field would this be better classified as a feat than a fix?

@powersj
Copy link
Contributor Author

powersj commented Nov 2, 2022

be better classified as a feat than a fix?

I debated this very question :) Since it is a field and not a tag I felt it was a fix, but you are right it is a new thing, so I'll set it to feat when I merge.

Thanks!

@powersj powersj merged commit 8221ece into influxdata:master Nov 2, 2022
@Hipska Hipska added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 2, 2022
@Hipska
Copy link
Contributor

Hipska commented Nov 2, 2022

Oh, already merged..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/system fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make n_users (System Input Plugin) configurable
3 participants