Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(outputs.yandex_cloud_monitoring): catch int64 values #12156

Merged
merged 2 commits into from
Nov 7, 2022
Merged

fix(outputs.yandex_cloud_monitoring): catch int64 values #12156

merged 2 commits into from
Nov 7, 2022

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Nov 3, 2022

fixes: #12155

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Nov 3, 2022
@powersj powersj mentioned this pull request Nov 3, 2022
Closed
sspaink
sspaink approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@sspaink sspaink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this so quickly!

srebhan
srebhan approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @powersj! One suggestion, but not a must.

plugins/outputs/yandex_cloud_monitoring/yandex_cloud_monitoring.go Outdated
// Write writes metrics to the remote endpoint
func (a *YandexCloudMonitoring) Write(metrics []telegraf.Metric) error {
var yandexCloudMonitoringMetrics []yandexCloudMonitoringMetric
for _, m := range metrics {
for _, field := range m.FieldList() {
value, err := setValue(field.Value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to use ToFloat64() of the internal package, but not a must.

Copy link
Contributor Author

@powersj powersj Nov 3, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh hey look at that! I'll use that. Thank you!

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Nov 3, 2022

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 4, 2022
@powersj powersj merged commit f2b49ce into influxdata:master Nov 7, 2022
@powersj powersj deleted the fix/12155 branch November 7, 2022 14:28
powersj added a commit that referenced this pull request Nov 29, 2022
@powersj
fix(outputs.yandex_cloud_monitoring): catch int64 values (#12156)
6d7cf29 
(cherry picked from commit f2b49ce)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sspaink sspaink sspaink approved these changes

@MyaLongmire MyaLongmire MyaLongmire approved these changes

@srebhan srebhan srebhan approved these changes

Assignees
No one assigned
Labels
fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic: interface conversion: interface {} is int64, not float64
4 participants
@powersj @sspaink @MyaLongmire @srebhan