Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.cloudwatch): Fix multiple namespaces issue #12177

Merged
merged 4 commits into from
Nov 7, 2022

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Nov 4, 2022

resolves #12172

This PR fixes an issue occurring when using multiple namespaces by moving the params declaration inside the namespace-loop in order to correctly reset the NextToken field. Otherwise, the cloudpoint API endpoint will send an error message (status-code 400) saying InvalidParameterValue: Parameters do not match original request parameters.
The PR also adds the logger to all unit-tests to be able to use it in the plugin. Furthermore, we deprecate the namespace option in favor of the namespaces option which can be used to specify multiple namespaces.

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Nov 4, 2022
@srebhan srebhan marked this pull request as draft November 4, 2022 13:57
@srebhan srebhan added the area/aws AWS plugins including cloudwatch, ecs, kinesis label Nov 4, 2022
@srebhan srebhan changed the title fix(inputs.cloudwatch): Add debug output fix(inputs.cloudwatch): Fix multiple namespaces issue Nov 7, 2022
@srebhan srebhan marked this pull request as ready for review November 7, 2022 13:21
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working to find this!

@srebhan srebhan merged commit 7445410 into influxdata:master Nov 7, 2022
@srebhan srebhan deleted the debug-new branch November 7, 2022 14:43
powersj pushed a commit that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/aws AWS plugins including cloudwatch, ecs, kinesis fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inputs.cloudwatch: Error when using multiple namespaces
2 participants