Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parsers.binary): Handle hex-encoded inputs #12232

Merged
merged 4 commits into from
Nov 16, 2022

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Nov 14, 2022

resolves #12234

This PR adds an option hex_encoding to enable handling of hex-encoded input data. If true, the input data is interpreted as a string containing the binary data in a hex-encoding, e.g. 40490e56 for the 32-bit IEE754 (big-endian) representation ofpi.
Input data containing spaces can be handled correctly (e.g. 40 49 0E 56) and encoding is case insensitive.

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins labels Nov 14, 2022
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 16, 2022
@srebhan srebhan requested a review from powersj November 16, 2022 11:42
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@powersj powersj merged commit d2268f0 into influxdata:master Nov 16, 2022
@srebhan srebhan deleted the binary_hex_encoded branch November 18, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to convert Hex to IEEE-754 Float from files with tail
2 participants