Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.cisco_telemetry_mdt): add operation-metric and class-policy #12240

Merged

Conversation

dd-accedian
Copy link
Contributor

@dd-accedian dd-accedian commented Nov 14, 2022

… prefixes

fix metrics getting overwritten when there are multiple class policies and operation metrics

Required for all PRs

resolves #8261

… prefixes

fix metrics getting overwrited when there are multiple class policies and operation metrics
@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Nov 14, 2022
@srebhan
Copy link
Contributor

srebhan commented Nov 15, 2022

@dd-accedian can you please sign the CLA and let me know once you are done?!?
We can only review and merge code where the author signed the CLA...

@srebhan srebhan self-assigned this Nov 15, 2022
@dd-accedian
Copy link
Contributor Author

!signed-cla

Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dd-accedian thanks for the contribution. I've just one small comment...

plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go Outdated Show resolved Hide resolved
fix(inputs.cisco_telemetry_mdt): switch instead of if statement for operation-metric and class-policy

Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@telegraf-tiger
Copy link
Contributor

Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the fix @dd-accedian!

@srebhan srebhan added area/cisco ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Jan 12, 2023
@srebhan srebhan assigned powersj and unassigned srebhan Jan 12, 2023
@powersj powersj merged commit 5174fb1 into influxdata:master Jan 12, 2023
srebhan pushed a commit that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cisco fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cisco_telemetry_mdt not working correctly with XR telemetry probe for Y1731 statistics
3 participants