Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.modbus): Add 8-bit integer types #12255

Merged
merged 4 commits into from
Nov 18, 2022

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Nov 16, 2022

resolves #10266

This PR adds the 8-bit integer types INT8L, INT8H, UINT8L and UINT8H for the low and high byte of the 16-bit register.

@telegraf-tiger telegraf-tiger bot added area/modbus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Nov 16, 2022
@telegraf-tiger
Copy link
Contributor

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this and the tests!

@srebhan srebhan merged commit 75aaa89 into influxdata:master Nov 18, 2022
@srebhan srebhan deleted the modbus_issue_10266 branch November 18, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/modbus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modbus plugin: support 8-bit values (boolean)
2 participants