Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.gnmi): Do not provide empty prefix for subscription request #12275

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Nov 23, 2022

resolves #12273

Do use a nil pointer instead of an empty path for prefix when creating a subscription request. This is necessary for (at least one) Huawei router(s) as they do not implement prefix support.

@srebhan srebhan marked this pull request as draft November 23, 2022 19:05
@telegraf-tiger telegraf-tiger bot added area/gnmi fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Nov 23, 2022
@jrventer
Copy link

@srebhan Tested this and looks like it is working correctly thanks.

@rasanentimo
Copy link

I also tested this with SONiC-OS-4.0.2-Enterprise Base on Dell S5248F and it's working as expected

@powersj
Copy link
Contributor

powersj commented Nov 28, 2022

@srebhan #12272 is merged, did you want to rebase this and then land?

@srebhan srebhan marked this pull request as ready for review November 28, 2022 18:21
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 28, 2022
@srebhan
Copy link
Contributor Author

srebhan commented Nov 28, 2022

@powersj exactly. Rebased now and ready for your comments! ;-)

@telegraf-tiger
Copy link
Contributor

@srebhan srebhan merged commit 54f4a3a into influxdata:master Nov 28, 2022
@srebhan srebhan deleted the gnmi_issue_12273 branch November 28, 2022 19:58
powersj pushed a commit that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gnmi fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gnmi plugin adds prefix with no content when building subscription
4 participants