Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs.socket_listener): Correctly close connection #12280

Merged
merged 1 commit into from
Nov 28, 2022
Merged

fix(inputs.socket_listener): Correctly close connection #12280

merged 1 commit into from
Nov 28, 2022

Conversation

srebhan
Copy link
Contributor

@srebhan srebhan commented Nov 24, 2022

resolves #12276

This PR fixes an issue where the socket-listener leaks connections in case the client (correctly) waits for the server to close the connection after sending FIN. This PR closes the connection correctly after read finishes and thus avoids the leakage.

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Nov 24, 2022
@srebhan srebhan added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin regression something that used to work, but is now broken and removed feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Nov 24, 2022
@srebhan srebhan mentioned this pull request Nov 24, 2022
Closed
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 25, 2022
powersj
powersj approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@powersj powersj merged commit 0e7a3c6 into influxdata:master Nov 28, 2022
powersj pushed a commit that referenced this pull request Nov 29, 2022
@srebhan @powersj
fix(inputs.socket_listener): ensure closed connection (#12280)
875b8e4 
(cherry picked from commit 0e7a3c6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

Assignees

@powersj powersj

Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. regression something that used to work, but is now broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

socket_listener input plugin leaking tcp connections
2 participants
@srebhan @powersj